Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pause #20

Merged
merged 2 commits into from
Jun 13, 2015
Merged

Test pause #20

merged 2 commits into from
Jun 13, 2015

Conversation

chriscool
Copy link
Collaborator

The first commit in this PR fixes issue #19 (Including test_pause()) by adding test_pause().
And the second commit fixes a small bug in sharness.t while at it.

@mlafeldt
Copy link
Collaborator

Thanks for the PR.

Please update API.md as well by running make doc.

Also, please add the documentation of test_pause to README.git as it was done in upstream.

As for the other commit, $SHELL_PATH seems to exist for a reason.

@chriscool
Copy link
Collaborator Author

Ok, I will update API.md.

About the documentation, test_pause is already documented in README.git there: https://github.com/mlafeldt/sharness/blob/master/README.git#L578, so I think you mean README.md.

@chriscool
Copy link
Collaborator Author

About $SHELL_PATH I know that in Git it should be used in test scripts.
But in Git it is set and exported, while in sharness, sharness.sh neither sets it nor exports it, so it cannot really be used in sharness test scripts right now.

If you mean that the right fix is to make sharness.sh set it and export it, then I can agree with that, but I think it is a bigger fix, though I may have a look at doing that if you think it is really needed and we agree about how to do it.

@chriscool chriscool mentioned this pull request May 29, 2015
Merged
@chriscool
Copy link
Collaborator Author

I have moved the $SHELL_PATH change into its own PR #21, so we can discuss it there.

@chriscool
Copy link
Collaborator Author

@mlafeldt could you have a look at the following changes:

  • The commit with $SHELL_PATH is now in another PR.
  • API.md has been regenerated using make doc.

Do you really want me to make some changes to README.git? It already has some information about test_pause:
https://github.com/mlafeldt/sharness/blob/master/README.git#L578

@whyrusleeping whyrusleeping mentioned this pull request Jun 9, 2015
Closed
50 tasks
@chriscool
Add test_pause() from Git
c3a055b 
Git has a test_pause() function that can be used to debug sharness tests:

https://github.com/git/git/blob/master/t/test-lib-functions.sh#L140

The README.git file also talks about it:

https://github.com/mlafeldt/sharness/blob/master/README.git#L578

Let's add it to sharness too.
@chriscool
API.md: regenerate doc after addind test_pause
0fcfd0c
@chriscool
Copy link
Collaborator Author

This is rebased on top of master and this is using SHELL_PATH instead of SHELL.

chriscool added a commit that referenced this pull request Jun 13, 2015
@chriscool
Merge pull request #20 from chriscool/test-pause
5eee9b5 
Test pause
@chriscool chriscool merged commit 5eee9b5 into felipec:master Jun 13, 2015
sinisterstumble pushed a commit to escapace/sharness that referenced this pull request Jan 3, 2018
@chriscool
Merge pull request felipec#20 from chriscool/test-pause
5925517 
Test pause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscool @mlafeldt