Fixed typos and grammatical errors in README #95
Conversation
There was a problem hiding this comment.
@richardcsuwandi thank you so much for fixing the typos! I need to ask you a few changes would you mind having a look?
|
|
||
|
|
||
| ## Feature-engine features in the following resources: |
There was a problem hiding this comment.
Feature-engine is an arbitrary name so for some reason I chose it to be F with capital and e with small one, and I wrote it that way in all docs. So I would prefer if we kept it this way. Could you reverse the change?
There was a problem hiding this comment.
Sure, I will change it back!
README.md
Outdated
| @@ -147,9 +147,9 @@ BSD 3-Clause | |||
|
|
|||
| ### References | |||
|
|
|||
| Many of the engineering and encoding functionality is inspired by this [series of articles from the 2009 KDD competition](http://www.mtome.com/Publications/CiML/CiML-v3-book.pdf). | |||
| Many of the engineering and encoding functionalities are inspired from this [series of articles from the 2009 KDD Competition](http://www.mtome.com/Publications/CiML/CiML-v3-book.pdf). | |||
There was a problem hiding this comment.
I think inspired should be by instead of from. Could we keep the original?
There was a problem hiding this comment.
You're right! Actually both are grammatically okay, but 'by' would be more suitable in this context.
README.md
Outdated
|
|
||
| To learn more about the rationale, functionality, pros and cos of each imputer, encoder and transformer, refer to the [Feature Engineering for Machine Learning, Online Course](https://www.udemy.com/feature-engineering-for-machine-learning/?couponCode=FEATENGREPO) | ||
| To learn more about the rationale, functionality, pros, and cons of each imputer, encoder, and transformer, refer to the [Feature Engineering for Machine Learning, Online Course](https://www.udemy.com/feature-engineering-for-machine-learning/?couponCode=FEATENGREPO) |
There was a problem hiding this comment.
could we remove the comma after pros?
There was a problem hiding this comment.
Oh yes, my bad! I will change that too!
Reversed some changes in fixed README
|
Hi, I've made some changes to the updated README as you suggested. Please kindly review it and let me know if there's anything I could help! |
I fixed some typos and grammatical errors in README to aid readability.