Add Branch and RC Awareness to Version Lint & Fix Semver Regex #998
Conversation
…branch TARGET_MERGE_BRANCH
…it easier to lint version.
mrzzy
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
|
/hold |
|
/unhold |
|
/test test-end-to-end-redis-cluster |
| elif echo "$BRANCH_NAME" | grep -P $RELEASE_BRANCH_REGEX &>/dev/null | ||
| then | ||
| # Use last release tag tagged on the release branch | ||
| LAST_MERGED_TAG=$(git tag -l --sort -version:refname --merged | head -n 1) |
There was a problem hiding this comment.
--merged would ensure lint-version will to work if user checks out a specific commit in a vX.Y-branch release branch as it only lists tags reachable from HEAD.
| if [ $BRANCH_NAME = "master" ] | ||
| then | ||
| # Use last stable tag repo wide | ||
| LAST_STABLE_TAG=$(git tag --sort -version:refname | grep -P "$STABLE_TAG_REGEX" | head -n 1) |
There was a problem hiding this comment.
This will break if the user tries to lint-version when checking out a specific commit in master as it does not take tag date into account.
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, mrzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test test-end-to-end-batch-dataflow |
1 similar comment
|
/test test-end-to-end-batch-dataflow |
…ex (#998) * Update version lint script to detect maven, docker image and stable version . * Allow users to lint versions against their merge branch of choice by branch TARGET_MERGE_BRANCH * Update development image tag version from 'dev' to 'develop' to make it easier to lint version. * Update lint version script to only echo file contents when version is wrong. * Update lint script to flag all failures instead of just one. * Remove file contents output from lint version script. * Update lint version script to make output more concise and readable. * Use develop images instead of stable images in master deployments. * Update outdated documentation in serving readme. * Fix outdated version in datatypes java README.md and add version lint check. * Add version lint checks to documentation. * Fix semver regex in github actions workflow not matching suffixless version tags. * Add version lint check for latest stable version in changelog. * Update lint-version script use tool agnostic variable names. * Fix typo.
Why we need it:
Currently the Feast deployments (helm, docker-compose) reference runs the last release version in the current master's infra.
Currently version lint will fail on master when a new release candidate in tagged in a vX.Y-branch release branch
What this PR does:
Updates version lint script to become branch aware:
developon master, versioned tag on vX.Y-branch release branches.Changes docker images used in master branch to
developdevdocker image tag todevelopto make it possible to lint (as implementation relies on counting references.)Improve version lint coverage to some docs with version:
Fixed bad regex introduced in #994 where it did not match version tag without prerelease suffix:
v0.7.1-rc.1properly but notv0.7.1Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: