Redis sink flushes only rows that have more recent eventTimestamp #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
|
/retest |
pyalex
force-pushed
the
redis-read-before-write
branch
from
3807415
to
07fc09c
Compare
pyalex
changed the title
|
/test test-end-to-end |
mrzzy
reviewed
Aug 1, 2020
| * @param <Input> | ||
| * @param <Output> | ||
| */ | ||
| public class BatchDoFnWithRedis<Input, Output> extends DoFn<Input, Output> { |
There was a problem hiding this comment.
There seems to be only one extension of this base class (RedisCustomIO.WriteDoFn). Is this base class necessary?
There was a problem hiding this comment.
Just wanted to separate redis wrapper code from business logic
woop
reviewed
Aug 1, 2020
storage/connectors/redis/src/main/java/feast/storage/connectors/redis/writer/RedisCustomIO.java
Show resolved
Hide resolved
woop
reviewed
Aug 1, 2020
|
/test test-end-to-end |
|
/test test-end-to-end-batch |
|
/lgtm |
woop
approved these changes
Aug 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
pyalex
pushed a commit
that referenced
this pull request
Aug 2, 2020
* redis sink read then write * fix load tests * e2e * fix * specify feature ref * move test up in order * set project default * some docs * reorder e2e tests * reorder e2e tests * reorder e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since we keep only one row per entity in Redis storage previously it was unpredictable which row will be written, especially in batch ingestion. In this PR we read existing value from redis first to compare eventTimestamps and only if row from stream has more recent eventTimestamp it will be written to store. This guarantees that more recent row won't be overwritten with older value. Now redis will have the latest value for entity.
Also, I refactored tests for redis sink to remove duplicated parts of code and use
@Parametrizedtests instead.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: