Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm installation docs - Fix broken link #808

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented Jun 19, 2020

What this PR does / why we need it:
Fix broken hyperlink to the required roles for the service account in Feast in Helm installation docs.

Which issue(s) this PR fixes:

Fixes #802

Does this PR introduce a user-facing change?:

No

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator Author

/retest

@woop woop merged commit fbb7a02 into feast-dev:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to BigQuery permissions for service account is broken
3 participants