Compression of FeatureRows collection in memory #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
|
/test test-end-to-end-batch |
|
/test test-end-to-end-batch-dataflow |
pyalex
changed the title
woop
reviewed
Jun 16, 2020
...s/bigquery/src/main/java/feast/storage/connectors/bigquery/compression/FeatureRowsBatch.java
Outdated
Show resolved
Hide resolved
woop
reviewed
Jun 16, 2020
...nectors/bigquery/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoadsWithResult.java
Show resolved
Hide resolved
make batch size parameter simplify creating jobId
|
/lgtm |
woop
approved these changes
Jun 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Recently we changed BigQuery writes to use BatchLoad method to be able to update table schema in-flight. In order to produce "successful inserts" output for metrics calculation we keep in memory all FeatureRows until BigQuery load job succeed.
To use memory more efficient this PR proposes to compress FeatureRows that awaiting for bq job to finish by converting them from row-orientation into column-orientation and using generic compression on those columns.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: