Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog #423

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Update Changelog #423

merged 3 commits into from
Jan 9, 2020

Conversation

woop
Copy link
Member

@woop woop commented Jan 9, 2020

What this PR does / why we need it:
It updates the current change log up to Feast 0.4.3

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop changed the title Initial commit of changelog up to 0.4.3 Update Changelog Jan 9, 2020
@woop
Copy link
Member Author

woop commented Jan 9, 2020

Ran into the following error during changelog generation

Warning: PR 412 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 407 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 388 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 382 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 380 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 374 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 372 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 370 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 360 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 244 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 241 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 240 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 238 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 236 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 235 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 234 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 232 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 227 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found

This means these PRs were NOT considered. Could be due to the PRs only being found on the non-master branch. Please go through them manually to ensure that they are captured.

CHANGELOG.md Show resolved Hide resolved
@khorshuheng
Copy link
Collaborator

khorshuheng commented Jan 9, 2020

Ran into the following error during changelog generation

Warning: PR 412 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 407 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 388 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 382 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 380 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 374 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 372 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 370 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 360 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 244 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 241 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 240 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 238 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 236 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 235 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 234 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 232 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 227 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found

This means these PRs were NOT considered. Could be due to the PRs only being found on the non-master branch. Please go through them manually to ensure that they are captured.

  • PR 244 and older are merged on 0.3-dev (or older), and was already on 0.3.0. Those can be ignored.
  • PR 412, 407, 360 are merged in branch 0.3 but not released.
  • PR 370, 372, 374, 388 are merged into project namespacing branch.
  • PR 380 is supposed to be on release 0.3.4 but ignored for some reason. Added manually.

@khorshuheng
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 0e31aef into feast-dev:master Jan 9, 2020
khorshuheng added a commit to khorshuheng/feast that referenced this pull request Feb 13, 2020
* Initial commit of changelog up to 0.4.3

* Remove unreleased changes on master

* Add missing changelog manually

Co-authored-by: Khor Shu Heng <32997938+khorshuheng@users.noreply.github.com>
davidheryanto pushed a commit that referenced this pull request Feb 13, 2020
* Update Changelog (#423)

* Initial commit of changelog up to 0.4.3

* Remove unreleased changes on master

* Add missing changelog manually

Co-authored-by: Khor Shu Heng <32997938+khorshuheng@users.noreply.github.com>

* Introduce datatypes/java module for proto generation (#391)

Rather than the Maven protobuf plugin running on the same symlinked
definitions in several Java modules, localize this process into one
module that the others depend on.

This provides a single module that can be depended on by third-party
extensions with the bare minimum of dependencies.

Also removes proto files that are no longer used.

* Update basic Feast example to Feast 0.4 (#424)

* Add documentation for bigquery batch retrieval (#428)

* Add documentation for bigquery batch retrieval

* Fix formatting for multiline comments

* Bump hibernate-validator from 6.0.13.Final to 6.1.0.Final in /ingestion (#421)

Bumps [hibernate-validator](https://github.com/hibernate/hibernate-validator) from 6.0.13.Final to 6.1.0.Final.
- [Release notes](https://github.com/hibernate/hibernate-validator/releases)
- [Changelog](https://github.com/hibernate/hibernate-validator/blob/master/changelog.txt)
- [Commits](hibernate/hibernate-validator@6.0.13.Final...6.1.0.Final)

Signed-off-by: dependabot[bot] <support@github.com>

* Publish datatypes/java along with sdk/java (#426)

This forward-ports a straggling commit from #407: it was missed when
initially creating the datatypes module because Sonatype publishing
setup was added concurrently.

* Remove "resource" concept and the need to specify a kind in feature sets (#432)

* Update GKE installation and chart values to work with 0.4.3 (#434)

* Fix logging (#430)

Allow log level to be set via environmental variable.
Add ability to set appender type in serving.
Remove logback-classic from ingestion as it is a library so should not bring its own impl.
Upgrade log4j to 2.12.1 to support objectMessageAsJsonObject.
Fix logger config targeting feast package in serving an add same concept for core.

* Bump chart version

* Update Changelog (#447)

* Update Changelog

* Remove closed issues

Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Co-authored-by: Ches Martin <ches@whiskeyandgrits.net>
Co-authored-by: Chen Zhiling <chnzhlng@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lionel Vital <lgvital@gmail.com>
Co-authored-by: Iain Rauch <Yanson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants