Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datetime.utcnow() to avoid timezone issues #2265

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

judahrand
Copy link
Member

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

What this PR does / why we need it:

Use datetime.now has the potential for timezone issues, especially when persisting the data to the Registry.

Which issue(s) this PR fixes:

Use datetime.utcnowinstead.

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand
Copy link
Member Author

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #2265 (2de9394) into master (592af75) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
+ Coverage   85.27%   85.42%   +0.15%     
==========================================
  Files         108      112       +4     
  Lines        9127     9593     +466     
==========================================
+ Hits         7783     8195     +412     
- Misses       1344     1398      +54     
Flag Coverage Δ
integrationtests 73.95% <100.00%> (+0.61%) ⬆️
unittests 58.60% <66.66%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/registry.py 83.28% <100.00%> (ø)
sdk/python/feast/diff/infra_diff.py 75.30% <0.00%> (-2.90%) ⬇️
sdk/python/feast/inference.py 84.84% <0.00%> (-2.66%) ⬇️
sdk/python/feast/data_source.py 60.55% <0.00%> (-0.74%) ⬇️
sdk/python/feast/errors.py 70.51% <0.00%> (-0.33%) ⬇️
sdk/python/feast/type_map.py 69.13% <0.00%> (-0.10%) ⬇️
sdk/python/feast/repo_config.py 88.82% <0.00%> (ø)
sdk/python/tests/integration/e2e/test_usage_e2e.py 100.00% <0.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 100.00% <0.00%> (ø)
sdk/python/feast/diff/FcoDiff.py
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592af75...2de9394. Read the comment docs.

@pyalex
Copy link
Collaborator

pyalex commented Feb 2, 2022

/lgtm

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 6e30457 into feast-dev:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants