Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache dynamodb client and resource in DynamoDB online store implement… #2138

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

felixwang9817
Copy link
Collaborator

…ation

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR caches the DynamoDB client and resource in the current online store implementation. Previously, the client and resource were reconstructed on each call to the online store, which cost ~80ms.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…ation

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #2138 (386d641) into master (192d3ad) will decrease coverage by 0.00%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
- Coverage   83.25%   83.24%   -0.01%     
==========================================
  Files         101      101              
  Lines        8162     8176      +14     
==========================================
+ Hits         6795     6806      +11     
- Misses       1367     1370       +3     
Flag Coverage Δ
integrationtests 73.41% <86.36%> (-0.32%) ⬇️
unittests 57.88% <27.27%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/dynamodb.py 81.67% <86.36%> (+1.33%) ⬆️
sdk/python/feast/infra/utils/aws_utils.py 84.05% <0.00%> (-0.73%) ⬇️
.../integration/online_store/test_universal_online.py 97.67% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192d3ad...386d641. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit 59031ca into feast-dev:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants