Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Template improvements (input prompt for configs, default to Redshift) #1731

Merged
merged 5 commits into from
Jul 28, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Jul 23, 2021

AWS Template improvements (input prompt for configs, default to Redshift)

Signed-off-by: Tsotne Tabidze tsotne@tecton.ai

What this PR does / why we need it: Currently AWS template uses dynamodb online store and file offline store. We're now changing the offline store to Redshift. However, Redshift needs to be configured by the user to make things work (e.g. cluster_id, database name, etc.). We don't have a mechanism for that. This PR adds python-inquirer library for user prompt during aws template bootstrap, which is used for configuring the feature_store.yaml. Here's the new flow in action:

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Allow configuring online & offline stores during AWS template, default to Redshift offline store

…ift)

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #1731 (d7649db) into master (489a0f8) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
- Coverage   79.08%   78.97%   -0.11%     
==========================================
  Files          80       80              
  Lines        6855     6878      +23     
==========================================
+ Hits         5421     5432      +11     
- Misses       1434     1446      +12     
Flag Coverage Δ
integrationtests 78.90% <66.66%> (-0.11%) ⬇️
unittests 61.71% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/client.py 26.23% <ø> (ø)
sdk/python/feast/constants.py 100.00% <ø> (ø)
sdk/python/feast/feature_store.py 93.47% <ø> (-0.03%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 97.08% <ø> (ø)
...k/python/feast/infra/offline_stores/file_source.py 85.91% <ø> (ø)
...thon/feast/infra/offline_stores/redshift_source.py 67.81% <0.00%> (ø)
sdk/python/feast/repo_config.py 92.62% <0.00%> (-1.64%) ⬇️
...gration/offline_store/test_historical_retrieval.py 98.95% <ø> (ø)
...hon/tests/integration/registration/test_cli_aws.py 100.00% <ø> (ø)
sdk/python/feast/driver_test_data.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489a0f8...d7649db. Read the comment docs.

@woop
Copy link
Member

woop commented Jul 23, 2021

/lgtm

sdk/python/setup.py Outdated Show resolved Hide resolved
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 27, 2021
Tsotne Tabidze added 2 commits July 27, 2021 13:54
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,tsotnet,woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsotnet tsotnet added kind/feature New feature or request ok-to-test labels Jul 28, 2021
@feast-ci-bot feast-ci-bot merged commit 95a245a into feast-dev:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants