-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test historical retrieval longer #1630
Make test historical retrieval longer #1630
Conversation
Hi @MattDelac. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
83c03a7
to
8c569d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
- Coverage 83.88% 83.87% -0.01%
==========================================
Files 67 67
Lines 5883 5911 +28
==========================================
+ Hits 4935 4958 +23
- Misses 948 953 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
8c569d3
to
55b06c2
Compare
/kind housekeeping |
/ok-to-test |
@MattDelac: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
So, 3 seconds? Looks good to me, but curious how much time this took before then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, MattDelac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
What this PR does / why we need it:
In order to have confidence in merging #1602, we want to also benchmark the tests performing historical retrieval on "larger" datasets.
This will ensure that a change in the template
SINGLE_FEATURE_VIEW_POINT_IN_TIME_JOIN
won't slow down the operationsWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
NONE