Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a specific error for missing columns during materialization #1619

Merged
merged 5 commits into from
Jun 11, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jun 3, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Follow up from #1615 based on the comment in #1614 . Also adds test and removed an empty file.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #1619 (2ff2504) into master (008a9ea) will increase coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   77.61%   77.63%   +0.02%     
==========================================
  Files          66       66              
  Lines        5789     5799      +10     
==========================================
+ Hits         4493     4502       +9     
- Misses       1296     1297       +1     
Flag Coverage Δ
unittests 77.63% <81.81%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/file.py 96.70% <50.00%> (+0.03%) ⬆️
sdk/python/feast/errors.py 64.28% <75.00%> (+1.12%) ⬆️
sdk/python/tests/test_e2e_local.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008a9ea...2ff2504. Read the comment docs.

sdk/python/feast/errors.py Outdated Show resolved Hide resolved
@achals achals force-pushed the achal/file-validation-test branch from 8db43cb to 26c4aa6 Compare June 7, 2021 18:52
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals force-pushed the achal/file-validation-test branch 3 times, most recently from 859c842 to 751eeb1 Compare June 9, 2021 18:51
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals force-pushed the achal/file-validation-test branch from 2ff2504 to 44b07eb Compare June 9, 2021 19:11
@achals
Copy link
Member Author

achals commented Jun 9, 2021

@woop ready for re-review

@woop
Copy link
Member

woop commented Jun 9, 2021

/lgtm

@achals achals requested a review from woop June 9, 2021 23:38
@achals
Copy link
Member Author

achals commented Jun 11, 2021

@woop for some reason this didn't get auto-merged - can you approve if it looks okay?

@woop woop merged commit 1fd030c into feast-dev:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants