Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpcio version in python SDK #1508

Merged

Conversation

szalai1
Copy link
Contributor

@szalai1 szalai1 commented Apr 27, 2021

What this PR does / why we need it:
Feast pins the grpcio dependency version to 1.31.0, which makes hard to use with other packages that requires higher version. (In our case it's Dagster , that requires >=1.32.0 )
This PR changes the grpcio version from 1.31.0 to 1.32. (Happy to change it even further)
Which issue(s) this PR fixes:
Haven't opened an issue, but happy to do if you want.
Fixes #

Does this PR introduce a user-facing change?:
NONE

@feast-ci-bot
Copy link
Collaborator

@szalai1: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

Hi @szalai1. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
@szalai1 szalai1 force-pushed the szala1/python-sdk-grpcio-version-bump branch from c38842e to a531d0e Compare April 27, 2021 07:34
@szalai1
Copy link
Contributor Author

szalai1 commented Apr 27, 2021

Question: This will cause a mismatch between the go grpcio version and the python one, shall I change that too? or just scratch my own itch.

@woop
Copy link
Member

woop commented Apr 27, 2021

/ok-to-test

@woop
Copy link
Member

woop commented Apr 27, 2021

Thanks @szalai1.

Should we perhaps use a more relaxed version (like what Dagster does with grpcio>=1.32.0")?

I dont think it's necessary to update Go right now. I can't see a reason why they would be incompatible.

@woop woop assigned tsotnet and jklegar and unassigned tsotnet Apr 27, 2021
@szalai1 szalai1 requested a review from a team as a code owner April 28, 2021 04:59
@szalai1
Copy link
Contributor Author

szalai1 commented Apr 28, 2021

thanks @woop for the quick review. Changed the version requirement.

Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
@szalai1 szalai1 force-pushed the szala1/python-sdk-grpcio-version-bump branch from 959c047 to e833750 Compare April 28, 2021 05:02
@jklegar
Copy link
Collaborator

jklegar commented May 1, 2021

/ok-to-test

@jklegar
Copy link
Collaborator

jklegar commented May 1, 2021

/kind housekeeping

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, szalai1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
Copy link
Collaborator

jklegar commented May 1, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit ece6440 into feast-dev:master May 1, 2021
jklegar pushed a commit to jklegar/feast that referenced this pull request May 12, 2021
* Upgrade grpcio version in python SDK

Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>

* Set grpcio version requirements to >=1.32.0

Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
jklegar pushed a commit that referenced this pull request May 12, 2021
* Upgrade grpcio version in python SDK

Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>

* Set grpcio version requirements to >=1.32.0

Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants