Fix Feature Table not updated on new feature addition #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
|
/test test-end-to-end-gcp |
pyalex
approved these changes
Nov 30, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test test-end-to-end-gcp |
1 similar comment
|
/test test-end-to-end-gcp |
|
/test test-end-to-end-aws |
pyalex
pushed a commit
that referenced
this pull request
Dec 4, 2020
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
Currently, the Feature Table doesn't get updated when new features is added to the specification. This is because the existing and new Feature Table are compared based on whether the new feature table contains all the existing features in the existing feature table, rather than strict equality.
In addition, the current Feature Table Spec is not working as intended as the test util for comparing expected and actual Feature Table spec always return True.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: