Update GetOnlineFeatures method in sdks #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-sdks
branch
from
dd4062f
to
7ab4ca7
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-sdks
branch
from
de0d62e
to
53b0ffc
Compare
pyalex
reviewed
Oct 15, 2020
pyalex
reviewed
Oct 15, 2020
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-sdks
branch
from
8ec3d6a
to
bd88ec0
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-sdks
branch
from
de1fdd8
to
2c266af
Compare
pyalex
approved these changes
Oct 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following PR to support serving request that handles new redis encoding, this PR adds support for new online feature retrieval across all sdk clients.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: