Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feast cli config file should be settable by an env var #149

Closed
tims opened this issue Mar 6, 2019 · 2 comments
Closed

Feast cli config file should be settable by an env var #149

tims opened this issue Mar 6, 2019 · 2 comments
Labels
good first issue Good for newcomers kind/feature New feature or request

Comments

@tims
Copy link
Contributor

tims commented Mar 6, 2019

Is your feature request related to a problem? Please describe.

If I have multiple feast instances, I want to be able to set different .feast files to configure the CLI.

Describe the solution you'd like

export FEAST_CONFIG=path/to/feast/configfile

it should default to ~/.feast
@tims tims added kind/feature New feature or request good first issue Good for newcomers labels Mar 6, 2019
@woop
Copy link
Member

woop commented Sep 1, 2019

This is a good issue. We can easily add a flag to the Python SDK to support this. For 0.3.0 the CLI is created from the SDK.

accraze added a commit to accraze/feast that referenced this issue Sep 4, 2019
@accraze
allow cli config path to be set by env var
448a85e 
fixes feast-dev#149
@accraze accraze mentioned this issue Sep 4, 2019
Merged
woop pushed a commit that referenced this issue Sep 7, 2019
@accraze @woop
allow cli config path to be set by env var
89cd543 
fixes #149
@woop
Copy link
Member

woop commented Oct 23, 2019

Closing this since @accraze completed this task with #244

@woop woop closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tims @woop