Add covariance, change fit data, more docs to Euler Deconvolution #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The covariance matrix will be needed to filter solutions in the windowed approach. Copied over some of the docstrings from the legacy Fatiando implementation, which expands the theory and provides links to good papers to read.
|
@Souza-junior I remembered after merging #493 that we had a lot of docs in the old Fatiando that could be copied over. The extra lines at the start of the fit method are used throughout Fatiando to help make all the inputs tuples of 1d arrays, which is easier to handle. They're very useful to allow inputs to be of any shape. |
|
@Souza-junior could you take a quick look and see what you think? |
|
@leouieda I'll take a closer look into it. |
|
@leouieda it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The covariance matrix will be needed to filter solutions in the windowed approach. Change the fit input to receive all the data in a single tuple, like the coordinates. This is more compatible with the rest of Fatiando. Added the checks for fit input and standardizing array shapes so inputs can be n-dimensional. Copied over some of the docstrings from the legacy Fatiando implementation, which expands the theory and provides links to good papers to read.