feat: validate types before other keywords, ajv-validator#485

farisn · May 13, 2017 · f60fedb · f60fedb
1 parent 6f0ff64
commit f60fedb
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 17 deletions.
diff --git a/lib/compile/rules.js b/lib/compile/rules.js
@@ -25,6 +25,7 @@ module.exports = function rules() {
   ];
   var TYPES = [ 'number', 'integer', 'string', 'array', 'object', 'boolean', 'null' ];
   RULES.all = toHash(ALL);
+  RULES.types = toHash(TYPES);
 
   RULES.forEach(function (group) {
     group.rules = group.rules.map(function (keyword) {
@@ -46,10 +47,11 @@ module.exports = function rules() {
       };
       return rule;
     });
+
+    if (group.type) RULES.types[group.type] = group;
   });
 
   RULES.keywords = toHash(ALL.concat(KEYWORDS));
-  RULES.types = toHash(TYPES);
   RULES.custom = {};
 
   return RULES;

diff --git a/lib/dot/validate.jst b/lib/dot/validate.jst
@@ -117,6 +117,11 @@
   var $errorKeyword;
   var $typeSchema = it.schema.type
     , $typeIsArray = Array.isArray($typeSchema);
+
+  if ($typeIsArray && $typeSchema.length == 1) {
+    $typeSchema = $typeSchema[0];
+    $typeIsArray = false;
+  }
 }}
 
 {{## def.checkType:
@@ -129,15 +134,6 @@
   if ({{= it.util[$method]($typeSchema, $data, true) }}) {
 #}}
 
-{{? $typeSchema && it.opts.coerceTypes }}
-  {{ var $coerceToTypes = it.util.coerceToTypes(it.opts.coerceTypes, $typeSchema); }}
-  {{? $coerceToTypes }}
-    {{# def.checkType }}
-      {{# def.coerceType }}
-    }
-  {{?}}
-{{?}}
-
 {{? it.schema.$ref && $refKeywords }}
   {{? it.opts.extendRefs == 'fail' }}
     {{ throw new Error('$ref: validation keywords used in schema at path "' + it.errSchemaPath + '" (see option extendRefs)'); }}
@@ -149,6 +145,29 @@
   {{?}}
 {{?}}
 
+{{? $typeSchema }}
+  {{? it.opts.coerceTypes }}
+    {{ var $coerceToTypes = it.util.coerceToTypes(it.opts.coerceTypes, $typeSchema); }}
+  {{?}}
+
+  {{ var $rulesGroup = it.RULES.types[$typeSchema]; }}
+  {{? $coerceToTypes || $typeIsArray || $rulesGroup === true ||
+    ($rulesGroup && !$shouldUseGroup($rulesGroup)) }}
+    {{
+      var $schemaPath = it.schemaPath + '.type'
+        , $errSchemaPath = it.errSchemaPath + '/type';
+    }}
+    {{# def.checkType }}
+      {{? $coerceToTypes }}
+        {{# def.coerceType }}
+      {{??}}
+        {{# def.error:'type' }}
+      {{?}}
+    }
+  {{?}}
+{{?}}
+
+
 {{? it.schema.$ref && !$refKeywords }}
   {{= it.RULES.all.$ref.code(it, '$ref') }}
   {{? $breakOnError }}
@@ -190,7 +209,6 @@
       {{? $rulesGroup.type }}
         }
         {{? $typeSchema && $typeSchema === $rulesGroup.type && !$coerceToTypes }}
-          {{ var $typeChecked = true; }}
           else {
             {{
               var $schemaPath = it.schemaPath + '.type'
@@ -209,12 +227,6 @@
   {{~}}
 {{?}}
 
-{{? $typeSchema && !$typeChecked && !$coerceToTypes }}
-  {{# def.checkType }}
-    {{# def.error:'type' }}
-  }
-{{?}}
-
 {{? $breakOnError }} {{= $closingBraces2 }} {{?}}
 
 {{? $top }}

diff --git a/spec/issues.spec.js b/spec/issues.spec.js
@@ -548,3 +548,31 @@ describe('issue #388, code clean-up not working', function() {
     should.equal(code.match(/[^\.]errors|vErrors/g), null);
   });
 });
+
+
+describe('issue #485, order of type validation', function() {
+  it('should validate types befor keywords', function() {
+    var ajv = new Ajv({allErrors: true});
+    var validate = ajv.compile({
+      type: ['integer', 'string'],
+      required: ['foo'],
+      minimum: 2
+    });
+
+    validate(2) .should.equal(true);
+    validate('foo') .should.equal(true);
+
+    validate(1.5) .should.equal(false);
+    checkErrors(['type', 'minimum']);
+
+    validate({}) .should.equal(false);
+    checkErrors(['type', 'required']);
+
+    function checkErrors(expectedErrs) {
+      validate.errors .should.have.length(expectedErrs.length);
+      expectedErrs.forEach(function (keyword, i) {
+        validate.errors[i].keyword .should.equal(keyword);
+      });
+    }
+  });
+});