Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(content/en/docs/running): add SKIP_DRIVER_LOADER option #226

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Jul 8, 2020

What type of PR is this?

/kind content

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

There was no reference to the SKIP_MODULE_LOAD within the documentation. Moreover, it was renamed to SKIP_DRIVER_LOADER recently (falcosecurity/falco#1297); thus, it's time to mention it under the "Running" section of the official documentation.
Finally, I also added a reference to the DRIVER_REPO env var under the same section since it can be useful in the same context.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Since the renaming (SKIP_MODULE_LOAD 👉 SKIP_DRIVER_LOADER) will be effective when Falco 0.24.0 is released, keep this on
/hold
until then.

/cc @fntlnz
/cc @leodido

leogr added 2 commits July 8, 2020 16:20
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana
Copy link

poiana commented Jul 8, 2020

LGTM label has been added.

Git tree hash: 96c008b90cff98bd59d14df024f46631577977cc

@poiana
Copy link

poiana commented Jul 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jul 8, 2020
@leogr
Copy link
Member Author

leogr commented Jul 16, 2020

/hold cancel

@poiana poiana merged commit 8afe468 into master Jul 16, 2020
@poiana poiana deleted the new/skip-driver-loader branch July 16, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants