Lazily throw exception in simple functions initialize() #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37666610 |
Differential Revision: D37259813 Registered format_datetime function, updated format_datetime implementation, began format_datetime tests D37259811 fbshipit-source-id: f6fd15bd87cc608803bc836fdd958c9053840de3
…bator#1957) Summary: Pull Request resolved: facebookincubator#1957 Lazily throwing exceptions in simple functions initialize(). If the initialize() method provided by simple functions throw, we can't let the exception bubble up immediately; rather, we need to capture the exception and only throw it if there are any active rows. . Consider the function "f(p1, c1)" where c1 is a constant that makes f() throw on initialize(). If we throw immediately on initialize() and p1 is composed only of nulls, the expected behavior would be to optimize this function out and return null, not to throw. This subtle semantic issue has been reported by Fuzzer runs. Reviewed By: kevinwilfong Differential Revision: D37666610 fbshipit-source-id: eedcdcae2bb394342752021bce514657dc9b894b
pedroerp
force-pushed
the
export-D37666610
branch
from
ca4ef7f
to
da29180
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37666610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lazily throwing exceptions in simple functions initialize().
If the initialize() method provided by simple functions throw, we can't let the
exception bubble up immediately; rather, we need to capture the exception and
only throw it if there are any active rows.
.
Consider the function "f(p1, c1)" where c1 is a constant that makes f()
throw on initialize(). If we throw immediately on initialize() and p1 is
composed only of nulls, the expected behavior would be to optimize this
function out and return null, not to throw. This subtle semantic issue
has been reported by Fuzzer runs.
Differential Revision: D37666610