Log message if bind(2) fails when looking up address for hostname #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This routine is called when initializing a device. It works by iterating over the set of addresses returned by getaddrinfo(3) and trying to bind to each of them. This is done to make sure we're not binding to an IPv6 address on an IPv4 only host and vice versa. Binding can fail if the machine is out of ports for that address, but it would raise an error saying it couldn't resolve an address for the hostname, which is wrong. Instead, it should raise an error saying that binding to a particular address failed. Differential Revision: D16437786 fbshipit-source-id: 6edf50374f84349f17985e4d6882b8ba157c934b
|
This pull request has been merged in 1ff2d84. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This routine is called when initializing a device. It works by
iterating over the set of addresses returned by getaddrinfo(3) and
trying to bind to each of them. This is done to make sure we're not
binding to an IPv6 address on an IPv4 only host and vice versa.
Binding can fail if the machine is out of ports for that address, but
it would raise an error saying it couldn't resolve an address for the
hostname, which is wrong. Instead, it should raise an error saying
that binding to a particular address failed.
Differential Revision: D16437786