Skip to content

Commit

Permalink
Trim EdenFS ODS time series
Browse files Browse the repository at this point in the history
Summary: Based on the discussion and poll results in https://fb.workplace.com/groups/edenfs/permalink/2464163713753846/ we decided to trim EdenFS ODS time-series. This diff remove rate, and 1 hour sliding window from the counters time-series histogram. Also, removbe P1 and P10 percentiles from the Duration ODS time-series.

Reviewed By: genevievehelsel

Differential Revision: D60126528

fbshipit-source-id: 87cf3889c8de033dcb9b88e835ff0fa4cf5ccdcf
  • Loading branch information
kavehahmadi60 authored and facebook-github-bot committed Jul 26, 2024
1 parent 14df652 commit 62e560f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions eden/common/telemetry/StatsGroup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ namespace facebook::eden {
StatsGroupBase::Counter::Counter(std::string_view name)
: Stat{
name,
fb303::ExportTypeConsts::kSumCountAvgRate,
fb303::ExportTypeConsts::kSumCountAvg,
// Don't record quantiles for counters. Usually "1" is the only value
// added. Usually we care about counts and rates.
{},
fb303::SlidingWindowPeriodConsts::kOneMinTenMinHour,
fb303::SlidingWindowPeriodConsts::kOneMinTenMin,
}, name_{name} {
// TODO: enforce the name matches the StatsGroup prefix.
}

StatsGroupBase::Duration::Duration(std::string_view name)
: Stat{
name,
fb303::ExportTypeConsts::kSumCountAvgRate,
fb303::QuantileConsts::kP1_P10_P50_P90_P99,
fb303::SlidingWindowPeriodConsts::kOneMinTenMinHour} {
fb303::ExportTypeConsts::kSumCountAvg,
fb303::QuantileConsts::kP50_P90_P95_P99,
fb303::SlidingWindowPeriodConsts::kOneMinTenMin} {
// This should be a compile-time check but I don't know how to spell that in a
// convenient way. :) Asserting at startup in debug mode should be sufficient.
XCHECK_GT(name.size(), size_t{3}) << "duration name too short";
Expand Down

0 comments on commit 62e560f

Please sign in to comment.