Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG.md ? #429

Open
thealjey opened this issue Jan 30, 2017 · 1 comment
Open

CHANGELOG.md ? #429

thealjey opened this issue Jan 30, 2017 · 1 comment

Comments

@thealjey
Copy link

Why don't you guys add a changelog to the project?
I'd like to know what changed in the fb-watchman api since version 1.9.2.
Please don't refer me to the commit history, I just cannot make any sense out of it 😊
@wez
Copy link
Contributor

wez commented Jan 30, 2017

We've not been great about this for the node modules, sorry!

This is the principle change:

75645d1

it impacts how numbers are returned. If your watchman queries are not including size or mtime fields in them, then you may have nothing to do to accommodate this change.

lencioni added a commit to Galooshi/import-js that referenced this issue Feb 26, 2017
@lencioni
Update fb-watchman 1.9.0 -> 2.0.0
d01cdba 
Although there is no changelog for this project, I found an issue that
outlines the breaking change in this version.

> This is the principle change:
>
> facebook/watchman@75645d13
>
> it impacts how numbers are returned. If your watchman queries are not
> including size or mtime fields in them, then you may have nothing to
> do to accommodate this change.

facebook/watchman#429 (comment)

We do query mtime. I'm not really sure how this change impacts our
project, but it seems like we should be fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wez @thealjey