Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiter priority to ReadOptions #9424

Closed
wants to merge 33 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
3c7107a
add ReadOptions::priority; basic plumbing to RandomAccessFileReader
ajkr Jan 24, 2022
044adfd
test nonzero compaction_readahead_bytes (path where FilePrefetchBuffe…
ajkr Jan 24, 2022
a7c9ee1
remove TODO for rate limiting a utility (SstFileDumper) code path
ajkr Jan 24, 2022
d21036d
add rate_limit_user_ops db_bench flag
ajkr Jan 24, 2022
63fba1c
add benchmarks for VerifyChecksum(), VerifyFileChecksums()
ajkr Jan 24, 2022
62adb1f
bug fix for VerifyChecksum() to use correct ReadOptions, rate_limiter
ajkr Jan 24, 2022
8268f3d
support more ReadOptions in new benchmarks
ajkr Jan 24, 2022
ab6ff84
db_bench option for file_checksum
ajkr Jan 24, 2022
eda989a
finish important parts of BlobFileReader
ajkr Jan 24, 2022
6274abf
remove impractical TODO
ajkr Jan 24, 2022
dc1d50c
more specific TODOs
ajkr Jan 24, 2022
7114e4b
clarify more TODOs
ajkr Jan 24, 2022
dcbe527
clarify api doc
ajkr Jan 24, 2022
797ea3b
update HISTORY.md
ajkr Jan 24, 2022
6532cdd
make format
ajkr Jan 24, 2022
b4f717a
complete list missing parts in API doc
ajkr Jan 24, 2022
c134a67
fix lite build
ajkr Jan 24, 2022
9ac84cc
basic test
ajkr Jan 25, 2022
36dde9a
fix lite
ajkr Jan 25, 2022
d333d11
try fix for no direct I/O support
ajkr Jan 25, 2022
a72a194
add MultiGet tests
ajkr Feb 2, 2022
649c99a
update doc for MultiGet
ajkr Feb 2, 2022
c3af9e6
make format
ajkr Feb 2, 2022
f7d91e9
add test for VerifyChecksum, VerifyFileChecksums
ajkr Feb 2, 2022
0e73a59
s/operation/option/
ajkr Feb 2, 2022
064e22d
remove API doc ref to non-public old BlobDB
ajkr Feb 2, 2022
855f161
API doc code reference for cuckoo/plain table
ajkr Feb 2, 2022
46a033d
API doc move small read details
ajkr Feb 2, 2022
9081582
update DBOptions::rate_limiter doc
ajkr Feb 2, 2022
9cda4cc
fix lite
ajkr Feb 2, 2022
b14fb92
rename priority -> rate_limiter_priority
ajkr Feb 3, 2022
10574a5
address comments
ajkr Feb 17, 2022
3c11f2b
fix visual studio compiler error
ajkr Feb 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove API doc ref to non-public old BlobDB
  • Loading branch information
ajkr committed Feb 16, 2022
commit 064e22d9d5658c73bcade3d10ae7b98a02d9174c
4 changes: 2 additions & 2 deletions include/rocksdb/options.h
Original file line number Diff line number Diff line change
Expand Up @@ -1565,8 +1565,8 @@ struct ReadOptions {
// special value `Env::IO_TOTAL` disables charging the rate limiter.
//
// The rate limiting is bypassed no matter this option's value for
// plain/cuckoo table reads, old BlobDB reads, and generally small reads like
// for file headers/footers.
// plain/cuckoo table reads, and generally small reads like for file
// headers/footers.
//
// The new `DB::MultiGet()` APIs (i.e., the ones returning `void`) will return
// `Status::NotSupported` when that operation requires file read(s) and
Expand Down