Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison warning of integers of different signs #748

Closed
wants to merge 1 commit into from

Conversation

tatzyr
Copy link
Contributor

@tatzyr tatzyr commented Nov 22, 2021

Motivation

The signs of framesInProcess (NSInteger) and MaxAllowedUnprocessedDataCounts (NSUInteger) do not match, resulting in a warning when comparing.

Test Plan

(Since we have only fix minor warnings, I don't think we need to test it.)

Related PRs

@facebook-github-bot
Copy link

@c-ryan747 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@c-ryan747 merged this pull request in 6d2df4d.

@tatzyr tatzyr deleted the comparable branch November 22, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants