Stop mysql syntax error exceptions #4312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RROR_JIT_STACKLIMIT when calling pcre_exec()
mgottein
changed the title
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D29409 |
mgottein
changed the title
|
Sorry, we're not going to take this. While yes, this is incompatible with PHP5, this is only incompatible when your SQL has a syntax error. Making this visible seems like a good thing. |
|
Throwing exceptions where PHP does not is not a good idea and doesn't seem like a good thing... I see the good side of it, but not when it is forced. |
|
We generally agree, however this isn't for a runtime error as such - this is showing a fundamental flaw in whatever PHP code triggers it, and likely a security issue at that. |
|
Also, this code already throws in PHP5 for other kinds of errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.