Exception getCode() is not final method

[cagataygurturk]

In original PHP Exception class getCode() has final keyword, not overridable. But in HHVM it can be overriden. It's an incompability.

See: http://3v4l.org/j5h20

Related with #4379

[hamidre13]

I will look at it.

[Majkl578]

@hamidre13: Have a look at http://php.net/manual/en/class.exception.php, there is probably more methods that need to be made final.

[hamidre13]

@Majkl578 : I will go through all of them.
Thanks

[Majkl578]

Hmm, any particular reason why this was reverted? cc @paroski @JoelMarcey

[paulbiss]

@Majkl578 see #4382

[Majkl578]

Yup I read that, this comment is older than the reply there.

[steelbrain]

Shouldn't this be re-opened?

[JoelMarcey]

@steelbrain: We can re-open the issue, good point; but can't re-open the pull request yet until we decide on a good course of action here.

[cagataygurturk]

Actually I do not understand why in Zend engine getCode() has final keyword. This incompatibility does not kill any cats in the world. Anyone that knows the rationale of final keyword in Zend engine?

[paulbiss]

Since cleaning this up will be a mess, and it's probably not going to matter much in the end I'm going to close this issue. If anyone can think of a good reason this method needs to be final please comment below.