Skip to content

Commit

Permalink
Apply improved autodeps
Browse files Browse the repository at this point in the history
Summary:
Apply autodeps improved in D60528917 to Thrift. This removes more than a thousand of unnecessary exported deps:

```
arc lint -a -- `find thrift -name BUCK`
arc lint -a -- `find thrift -name TARGETS`
```

This revealed missing dependencies in `common/thrift` (fixed by applying autodeps there as well) and `caffe2` (fixed manually since their build config is a bit of a mess).

Add a missing include to `thrift/lib/cpp2/async/ClientChannel.cpp`.

Mark a few targets that previously failed to build in xplat as fbcode-only so that they are not even generated there.

Reviewed By: thedavekwon, shayne-fletcher

Differential Revision: D60666956

fbshipit-source-id: 36531df2e28e788663bb13d80ddb1070d5ca5a06
  • Loading branch information
vitaut authored and facebook-github-bot committed Aug 3, 2024
1 parent e3e4de0 commit dba1823
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions thrift/lib/cpp2/async/ClientChannel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/

#include <thrift/lib/cpp2/Flags.h>
#include <thrift/lib/cpp2/async/ClientChannel.h>

#ifdef __linux__
Expand Down

0 comments on commit dba1823

Please sign in to comment.