Skip to content

Commit

Permalink
Consider upgrading fbcode/thrift/conformance/go's thrift.NewSimpleSer…
Browse files Browse the repository at this point in the history
…ver to use thrift.TransportIDUpgradeToRocket

Summary: Please consider upgrading fbcode/thrift/conformance/go's thrift.NewSimpleServer to use thrift.TransportIDUpgradeToRocket. See https://fb.workplace.com/groups/codegophers/permalink/26891400743815186/ for more details. Please test in production and let us know of any issues.

Reviewed By: thedavekwon

Differential Revision: D63321910

fbshipit-source-id: ab03e554e1e4599e8f918372bcbfeef74b97c8f8
  • Loading branch information
Walter Schulze authored and facebook-github-bot committed Sep 25, 2024
1 parent cb69dd5 commit 23aefd7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion thrift/conformance/go/conformance_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func newServer(processor thrift.Processor, addr string) (thrift.Server, net.Addr
if err != nil {
return nil, nil, err
}
return thrift.NewSimpleServer(processor, socket, thrift.TransportIDHeader), socket.Addr(), nil
return thrift.NewSimpleServer(processor, socket, thrift.TransportIDUpgradeToRocket), socket.Addr(), nil
}

type dataConformanceServiceHandler struct {
Expand Down
2 changes: 1 addition & 1 deletion thrift/conformance/go/rpc_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func newServer(processor thrift.Processor, addr string) (thrift.Server, net.Addr
if err != nil {
return nil, nil, err
}
return thrift.NewSimpleServer(processor, socket, thrift.TransportIDHeader), socket.Addr(), nil
return thrift.NewSimpleServer(processor, socket, thrift.TransportIDUpgradeToRocket), socket.Addr(), nil
}

type rpcConformanceServiceHandler struct {
Expand Down

0 comments on commit 23aefd7

Please sign in to comment.