chore(v2): upgrade Infima #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
commented
Apr 26, 2020
| @@ -66,7 +66,7 @@ function NavItem({items, position, ...props}) { | |||
| <ul className="dropdown__menu"> | |||
| {items.map((linkItemInner, i) => ( | |||
| <li key={i}> | |||
| <NavLink className="navbar__item navbar__link" {...linkItemInner} /> | |||
There was a problem hiding this comment.
Need to change this otherwise the carets will also show up for the dropdown items. We lose the active highlighting here sadly.
There was a problem hiding this comment.
Uh-huh, so for dropdown items we need to use only one CSS class of dropdown__link. Then we need to add an active dropdown item class to Infima and then specify it in the NavBar component. Right? I will fix it.
There was a problem hiding this comment.
The fix is ready, I'm waiting for the new version of Infima, which will define CSS class for active dropdown item.
|
Deploy preview for docusaurus-2 ready! Built with commit ca4a94a |
yangshun
force-pushed
the
yangshun/infima
branch
from
a538d14
to
85c6f4e
Compare
lex111
added
the
status: don't merge yet
yangshun
removed
the
status: don't merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade to
infima@0.2.0-alpha.8which brings about some typography changes and navbar caret.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See Netlify.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)