Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): hide mobile navbar hamburger when there are no links #2624

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Apr 18, 2020

Motivation

Fix #2623

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Commented out the themeConfig.links field in docusaurus.config.js and see that the hamburger doesn't appear.

Screen Shot 2020-04-18 at 11 52 40 AM

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 18, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 74e64a1

https://deploy-preview-2624--docusaurus-2.netlify.app

@yangshun yangshun merged commit 409f878 into master Apr 18, 2020
@benmccann
Copy link

Wow! Thank you so much for the quick fix!

@lex111 lex111 deleted the yangshun/navbar-empty-links branch April 18, 2020 16:45
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theme-classic(v2): navbar shows with no links
5 participants