Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): tweak colors for announcement bar #2505

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Apr 2, 2020

Motivation

Make the announcement more prominent.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Screen Shot 2020-04-02 at 2 26 35 PM

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun yangshun requested a review from lex111 April 2, 2020 06:27
@yangshun yangshun requested a review from wgao19 as a code owner April 2, 2020 06:27
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 2, 2020
@yangshun yangshun added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 2, 2020
@lex111
Copy link
Contributor

lex111 commented Apr 2, 2020

See also #2504

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 2, 2020

Deploy preview for docusaurus-2 ready!

Built with commit ff5e8cc

https://deploy-preview-2505--docusaurus-2.netlify.com

@yangshun
Copy link
Contributor Author

yangshun commented Apr 2, 2020

@lex111 what do you think of using the default primary color?

@lex111
Copy link
Contributor

lex111 commented Apr 2, 2020

It doesn't go well with bg color, IMO.

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But OK.

@yangshun yangshun merged commit f51b564 into master Apr 2, 2020
@yangshun
Copy link
Contributor Author

yangshun commented Apr 2, 2020

I changed the color to be black

@yangshun yangshun deleted the ys/announcement branch April 2, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants