Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint complaints in build.js #7870

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Conversation

andriijas
Copy link
Contributor

Eslint made the e2e exit

Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andriijas can you please revert the lockfile change?

I had this too... it's an annoying part of our E2E tests running locally.

@andriijas
Copy link
Contributor Author

@mrmckeb fixed, sorry about that!

@andriijas andriijas merged commit 4582491 into facebook:master Oct 24, 2019
@andriijas andriijas deleted the hopfix branch October 24, 2019 10:43
@mrmckeb
Copy link
Contributor

mrmckeb commented Oct 24, 2019

NP!

@lock lock bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants