flake8 fixes #1752
Closed
flake8 fixes #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47931988 |
Differential Revision: D47929289 fbshipit-source-id: 64308697c65a42838d795e63ac633a4cfff65b45
Summary: Pull Request resolved: facebook#1752 Looks like flake8 became a bit more strict with type comparisons. This fixes the failures raised in https://github.com/facebook/Ax/actions/runs/5719204578/job/15496614136 Reviewed By: Balandat Differential Revision: D47931988 fbshipit-source-id: 5bce0cfbdfeefef4fafb0f447bfface96535e3cd
saitcakmak
force-pushed
the
export-D47931988
branch
from
61bfbf5
to
0850bc6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47931988 |
|
Thanks for jumping on this quickly! |
esantorella
approved these changes
Jul 31, 2023
|
This pull request has been merged in feab1f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Looks like flake8 became a bit more strict with type comparisons. This fixes the failures raised in https://github.com/facebook/Ax/actions/runs/5719204578/job/15496614136
Reviewed By: Balandat
Differential Revision: D47931988