Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / silence Pyre failures due to latest GPyTorch changes #1642

Closed
wants to merge 1 commit into from
Closed

Fix / silence Pyre failures due to latest GPyTorch changes #1642

wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary: Turns out Pyre really doesn't like GPyTorch and the only thing keeping it sane was a __getattr__ method with no return type.

Differential Revision: D46409697

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jun 2, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46409697

saitcakmak added a commit to saitcakmak/Ax that referenced this pull request Jun 3, 2023
@saitcakmak @facebook-github-bot
Fix / silence Pyre failures due to latest GPyTorch changes (facebook#…
7185f6d 
…1642)

Summary:
Pull Request resolved: facebook#1642

Turns out Pyre really doesn't like GPyTorch and the only thing keeping it sane was a `__getattr__` method with no return type.

Differential Revision: D46409697

fbshipit-source-id: 6a88c83c6ea92c1a80d99e4ba6a389897f4315f4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46409697

saitcakmak added a commit to saitcakmak/Ax that referenced this pull request Jun 5, 2023
@saitcakmak @facebook-github-bot
Fix / silence Pyre failures due to latest GPyTorch changes (facebook#…
2c25dd7 
…1642)

Summary:
Pull Request resolved: facebook#1642

Turns out Pyre really doesn't like GPyTorch and the only thing keeping it sane was a `__getattr__` method with no return type.

Reviewed By: esantorella

Differential Revision: D46409697

fbshipit-source-id: 00644734a73cc0bc625eb8604b99a6cf9fd9dbcb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46409697

@saitcakmak @facebook-github-bot
Fix / silence Pyre failures due to latest GPyTorch changes (facebook#…
74ff716 
…1642)

Summary:
Pull Request resolved: facebook#1642

Turns out Pyre really doesn't like GPyTorch and the only thing keeping it sane was a `__getattr__` method with no return type.

Reviewed By: esantorella

Differential Revision: D46409697

fbshipit-source-id: cd032046158e59bcbb41151dcc03fcedc7706e78
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46409697

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.01 ⚠️

Comparison is base (94c02eb) 94.79% compared to head (6635a45) 94.78%.

❗ Current head 6635a45 differs from pull request most recent head 74ff716. Consider uploading reports for the commit 74ff716 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files         444      444              
  Lines       41051    41063      +12     
==========================================
+ Hits        38913    38921       +8     
- Misses       2138     2142       +4
Impacted Files Coverage Δ
ax/models/torch/fully_bayesian_model_utils.py 100.00% <ø> (ø)
ax/models/torch/tests/test_surrogate.py 99.78% <ø> (ø)
ax/utils/stats/statstools.py 92.15% <ø> (ø)
ax/utils/common/testutils.py 80.34% <20.00%> (-1.42%) ⬇️
ax/models/tests/test_alebo.py 100.00% <100.00%> (ø)
ax/models/tests/test_botorch_defaults.py 100.00% <100.00%> (ø)
ax/models/torch/alebo.py 99.64% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7f99460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saitcakmak @facebook-github-bot @codecov-commenter