Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up workflow pip installs, run tests on Py3.10 #1138

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary: As titled. The # of pip install statements were getting out of hand...

Differential Revision: D39519257

Summary: As titled. The # of `pip install` statements were getting out of hand...

Differential Revision: D39519257

fbshipit-source-id: b520635b87442fa970ccbfab5660e8786caab91a
@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Sep 14, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39519257

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtmtl, thanks

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Base: 94.82% // Head: 94.81% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7a1b244) compared to base (57c53ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   94.82%   94.81%   -0.01%     
==========================================
  Files         411      411              
  Lines       36534    36555      +21     
==========================================
+ Hits        34643    34661      +18     
- Misses       1891     1894       +3     
Impacted Files Coverage Δ
ax/utils/common/tests/test_docutils.py 76.19% <0.00%> (-4.77%) ⬇️
ax/models/torch/tests/test_optimizer_argparse.py 95.58% <0.00%> (-1.48%) ⬇️
ax/service/tests/test_scheduler.py 98.98% <0.00%> (-0.51%) ⬇️
ax/modelbridge/factory.py 100.00% <0.00%> (ø)
ax/modelbridge/registry.py 100.00% <0.00%> (ø)
ax/storage/metric_registry.py 100.00% <0.00%> (ø)
ax/storage/transform_registry.py 100.00% <0.00%> (ø)
ax/modelbridge/modelbridge_utils.py 100.00% <0.00%> (ø)
ax/service/utils/instantiation.py 98.20% <0.00%> (+<0.01%) ⬆️
ax/early_stopping/tests/test_strategies.py 99.59% <0.00%> (+0.01%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants