Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable in choose_generation_strategy #341

Closed
andyznew opened this issue Jul 1, 2020 · 2 comments
Closed

Unused variable in choose_generation_strategy #341

andyznew opened this issue Jul 1, 2020 · 2 comments
Assignees
@lena-kashtelyan
Labels
fixready Fix has landed on master.

Comments

@andyznew
Copy link

andyznew commented Jul 1, 2020

no_max_parallelism: bool = False, is not used in the code, a relic of the past (https://github.com/facebook/Ax/blob/master/ax/modelbridge/dispatch_utils.py#L125). Not really a blocking issue but probably a todo to get rid of sometime
@Jakepodell
Copy link
Contributor

This is a great call, thanks @andyznew for bringing this to our attention! :)

@lena-kashtelyan lena-kashtelyan self-assigned this Jul 2, 2020
facebook-github-bot pushed a commit that referenced this issue Jul 16, 2020
@glennq @facebook-github-bot
Remove unused variable in choose_generation_strategy
2d478fa 
Summary:
As reported by an issue in github (#341)
This variable `no_max_parallelism` is not used by `choose_generation_strategy` but is still one of the functions input arguments.
Cleaning it up in this diff

Reviewed By: lena-kashtelyan

Differential Revision: D22576370

fbshipit-source-id: 13c3d41b2c66151508a8d5e1290ff73b0601010f
@lena-kashtelyan lena-kashtelyan added the fixready Fix has landed on master. label Jul 17, 2020
@lena-kashtelyan
Copy link
Contributor

This is now fixed on the latest stable version, 0.1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lena-kashtelyan lena-kashtelyan

Labels
fixready Fix has landed on master.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jakepodell @andyznew @lena-kashtelyan