Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Anthropic endpoints #230

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix Anthropic endpoints #230

merged 1 commit into from
Jul 25, 2023

Conversation

ljvmiranda921
Copy link
Contributor

@ljvmiranda921 ljvmiranda921 commented Jul 25, 2023 •
edited
Loading

Some of the chat endpoints should return the actual value.

Types of change

Bug fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ljvmiranda921 ljvmiranda921 added the bug Something isn't working label Jul 25, 2023
@ljvmiranda921 ljvmiranda921 self-assigned this Jul 25, 2023
rmitsch
rmitsch approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@rmitsch rmitsch merged commit c52d062 into main Jul 25, 2023
9 checks passed
@svlandeg svlandeg deleted the fix/anthropic-endpoints branch July 25, 2023 14:29
@svlandeg svlandeg added the feat/model Feature: models label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmitsch rmitsch rmitsch approved these changes

Assignees

@ljvmiranda921 ljvmiranda921

Labels
bug Something isn't working feat/model Feature: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljvmiranda921 @rmitsch @svlandeg