inlineStr cell type support #1575 #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a new test with that test file to make sure we don't lose this functionality over time? |
|
@alubbe, added integration test with the sample file. |
|
@Siemienik, could you please review and merge this PR? |
|
Yes, I will if only I found free time. |
alubbe
approved these changes
Sep 7, 2021
|
When will this be released? |
|
when will this be release, because right now in "4.3.0" also this fix is not present. We are getting the inlineStr cell as "NULL", please make a small release for this issue, if possible... Currently we are using the npm release version. Do we have to pull from github directly and then use the fix, or will you be making a release in npm also ? |
|
@Siemienik please release a new version with this fix |
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing inlineStr cell type fixing issue #1575
Test plan
Tested stream reading of the xlsx file that has cells defined as
<c ... t="inlineStr"><is><t>value here</t></is></c>- values gets populated, instead of null values before the fix.