-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-6072 Add new degraded mode associated limits #8089
Conversation
model/project_parser_s3.go
Outdated
@@ -12,6 +12,9 @@ import ( | |||
"go.mongodb.org/mongo-driver/bson" | |||
) | |||
|
|||
// sizeLimit is a hard limit on parser project size. | |||
const sizeLimit = 1024 * 1024 * 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a hard-coded size limit? I thought the parser project size was supposed to be configurable from the admin settings so we could incrementally raise it in a controlled way.
I believe the actual current limitation is below 50 MB (depending on the concurrency setting), so we would likely want to adjust this value over time (on top of the degraded size limit) as we understand what Evergreen can and can't tolerate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this to be more easily changeable.
I'm not aware of any current limitation beyond the 16MB document limit though:
I believe the actual current limitation is below 50 MB (depending on the concurrency setting)
Where can I find this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod suggestion about using MB as the unit instead of plain bytes.
<md-input-container class="control" style="width:45%;"> | ||
<label>Max Parser Project Size</label> | ||
<input type="number" ng-model="Settings.task_limits.max_parser_project_size"> | ||
</md-input-container> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might be slightly nicer if these were expressed in MB (or otherwise, if the admin settings page clarified that the unit is bytes vs. MB).
DEVPROD-6072
Description
There will be a followup PR that makes use of these two new limits.
Testing
Existing