EVG-20943: Ensure virtual workstation is Linux architecture #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minnakt
approved these changes
Sep 28, 2023
validator/distro_validator.go
Outdated
|
|
||
| if !utility.StringSliceContains(linuxDistros, d.Arch) { | ||
| errs = append(errs, ValidationError{ | ||
| Message: "spawnable distros must use Linux architecture", |
There was a problem hiding this comment.
should this say workstation distros? some windows distros are user spawnable on prod
Kimchelly
approved these changes
Sep 29, 2023
validator/distro_validator.go
Outdated
|
|
||
| if !utility.StringSliceContains(linuxDistros, d.Arch) { | ||
| errs = append(errs, ValidationError{ | ||
| Message: "workstation distros must use Linux architecture", |
There was a problem hiding this comment.
nit: The phrasing is a little weird because Linux isn't an architecture. The arch enum represents a combination of OS + CPU architecture, so phrasing this as "workstation distros must use Linux with a supported CPU architecture" (or something like that) would sound less ambiguous.
validator/distro_validator.go
Outdated
| @@ -547,6 +547,20 @@ func ensureHasValidVirtualWorkstationSettings(ctx context.Context, d *distro.Dis | |||
| Level: Error, | |||
| }) | |||
| } | |||
| linuxDistros := []string{ | |||
There was a problem hiding this comment.
nit: maybe allowedArchs (arches...?) or linuxArchs since distros aren't relevant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-20943
Description
Testing
Documentation
N/A