Don't decode and re-encode URLs unnecessarily. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes two problems: - '+' gets incorrectly decoded to ' ' - '%2B' gets decoded to '+', but not encoded back to '%2B', resulting in a slightly different URL Fixes evanmiller#95
|
Thanks! |
dimaryaz
added a commit
to quiltdata/mod_zip
that referenced
this pull request
Feb 11, 2023
This reverts evanmiller#96, with the exception of not decoding '+' to ' '. The change in evanmiller#96 fixed evanmiller#95 but introduced evanmiller#102. It appears to be impossible to fix both bugs without modifying Nginx itself. However, the second part of the original bug was really a problem with S3 rather than mod_zip, so mod_zip functionality should take priority. Therefore, bring back original behavior - except for decoding '+' to ' ', which was still a bug in mod_zip. This fixes evanmiller#102.
evanmiller
pushed a commit
that referenced
this pull request
Feb 13, 2023
This reverts #96, with the exception of not decoding '+' to ' '. The change in #96 fixed #95 but introduced #102. It appears to be impossible to fix both bugs without modifying Nginx itself. However, the second part of the original bug was really a problem with S3 rather than mod_zip, so mod_zip functionality should take priority. Therefore, bring back original behavior - except for decoding '+' to ' ', which was still a bug in mod_zip. This fixes #102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes two problems:
Fixes #95