Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux support #1

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Add Linux support #1

merged 1 commit into from
Feb 2, 2020

Conversation

toluschr
Copy link

Since me and perhaps some other people might want to use this script on Linux, I added support for it.

I also analyzed your script using shellcheck. It reported that exit codes should have a value from 0-255. I corrected this.

@toluschr
Copy link
Author

I noticed that my editor used tabs instead of spaces, when I saved the document.
I corrected this and squashed the commits.

@eugr
Copy link
Owner

eugr commented Jan 29, 2020

Thanks! For some reason I haven't got any notifications about this pull request. I'll check if it breaks anything on Mac and merge if everything is good.

@eugr
Copy link
Owner

eugr commented Jan 30, 2020

@toluschr - any reason you got rid of sort in the pipeline? I used it to make sure we always update the latest Cura version.

@toluschr
Copy link
Author

toluschr commented Jan 31, 2020

It worked without sort when I tested it, but I can add the sort back in if you want

@eugr
Copy link
Owner

eugr commented Jan 31, 2020

Yeah, let's add it back is this 'find' behavior is not guaranteed on all platforms.

@toluschr
Copy link
Author

toluschr commented Feb 1, 2020

I made the changes to the install script

@eugr eugr merged commit 1a3ee22 into eugr:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants