EtherscanProvider has no base URL for Optimism

[eliotstock]

Ethers Version

5.6.5

Search Terms

optimism etherscan

Describe the Problem

Versions of the Etherscan API that enable historical queries (using EtherscanProvider.getHistory(address)) now exist for some L2 chains, including Optimistic Ethereum: https://optimistic.etherscan.io/apis. However, it's not yet possible to use this in Ethers.js AFAICT.

This code...

  const network: Network = {name: 'optimism', chainId: 10}
  const provider = new EtherscanProvider(network, etherscanApiKey)

... will throw:

ReferenceError: name is not defined
    at EtherscanProvider.getBaseUrl (/home/e/r/dro/interface/node_modules/@ethersproject/providers/src.ts/etherscan-provider.ts:189:76)
    at new EtherscanProvider (/home/e/r/dro/interface/node_modules/@ethersproject/providers/src.ts/etherscan-provider.ts:170:46)
    at main (/home/e/r/dro/interface/src/index.ts:48:30)

... because getBaseUrl() here doesn't know about Optimism.

I've also tried using the JsonRpcProvider and providing a URL:

const network: Network = {name: 'optimism', chainId: 10}
provider = new JsonRpcProvider('https://api-optimistic.etherscan.io/api', network)

But of course there's no getHistory() method on JsonRpcProvider.

Code Snippet

const network: Network = {name: 'optimism', chainId: 10}
  const provider = new EtherscanProvider(network, etherscanApiKey)

Contract ABI

No response

Errors

ReferenceError: name is not defined
    at EtherscanProvider.getBaseUrl (/home/e/r/dro/interface/node_modules/@ethersproject/providers/src.ts/etherscan-provider.ts:189:76)
    at new EtherscanProvider (/home/e/r/dro/interface/node_modules/@ethersproject/providers/src.ts/etherscan-provider.ts:170:46)
    at main (/home/e/r/dro/interface/src/index.ts:48:30)

Environment

Altcoin - Please specify (e.g. Polygon), node.js (v12 or newer)

Environment (Other)

Optimism

[ricmoo]

This has been added in 5.6.6.

Let me know if you have any problems.

Thanks! :)

[eliotstock]

Amazing, thank you so much!