Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toDot utility method to SSA control flow graphs #15438

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

clonker
Copy link
Member

@clonker clonker commented Sep 18, 2024

formerly implemented in test suite but I found myself needing it also in intermediate steps to visualize the current state of the graph when debugging things

Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just have some nitpicks that we ignored when merging in the test, that maybe we could quickly fix, but I'm fine in merging without it as well :)

libyul/backends/evm/SSAControlFlowGraph.cpp Show resolved Hide resolved
libyul/backends/evm/SSAControlFlowGraph.cpp Outdated Show resolved Hide resolved
libyul/backends/evm/SSAControlFlowGraph.cpp Outdated Show resolved Hide resolved
libyul/backends/evm/SSAControlFlowGraph.cpp Outdated Show resolved Hide resolved
libyul/backends/evm/SSAControlFlowGraph.cpp Outdated Show resolved Hide resolved
@clonker clonker merged commit db40301 into develop Sep 18, 2024
72 checks passed
@clonker clonker deleted the ssaCfg-todot branch September 18, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants