trie, core, eth: use db.has over db.get where possible #24117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finished a snap-sync (with blocks already present): https://geth-bench.ethdevops.io/d/Jpk-Be5Wk/dual-geth?orgId=1&from=1639661782210&to=1639685566480 . No obvious difference in charts, but it seems at least that it doesn't break anything. |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 11, 2022
trie, core, eth: use db.has over db.get where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some syncs, I noticed that in the heal phase, the db reads is going through the roof. This PR aims to bring that down a little bit, or at least reduce some allocation when that happens, by using
db.Haswherever possible.I'll do a benchmark later, also to verify that it doesn't break anything.