Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadcn migration - nav leftovers #13849

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Shadcn migration - nav leftovers #13849

merged 4 commits into from
Sep 16, 2024

Conversation

pettinarip
Copy link
Member

Description

This PR includes a few leftovers from #13647 which completes the migration for the Nav component.

  • Removes the useNavMenuColors and useNavMenuColorsTw hooks to control the style classes for the Nav and mobile Nav components

Related Issue

#13647

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a01ac89
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66e1aabeeeed290008a4e565
😎 Deploy Preview https://deploy-preview-13849--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 36 (🔴 down 12 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 88 (🔴 down 4 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Sep 11, 2024
@wackerow wackerow merged commit 556445f into dev Sep 16, 2024
8 of 10 checks passed
@wackerow wackerow deleted the shadcn-nav-leftovers branch September 16, 2024 18:23
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants