Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix the labeler #2427

Merged
merged 2 commits into from
Apr 6, 2022
Merged

ci: Fix the labeler #2427

merged 2 commits into from
Apr 6, 2022

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Apr 5, 2022

The labeler wasn't applying C-Protocol-Critical labels correctly. I misinterpreted how the any rule was supposed to work.

@mslipper
ci: Fix the labeler
90ef98c 
The labeler wasn't applying `C-Protocol-Critical` labels correctly. I misinterpreted how the `any` rule was supposed to work.
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 86a48b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly April 5, 2022 23:39
Inphi
Inphi approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah, the docs are kinda confusing on its usage.

@mergify mergify bot requested a review from Inphi April 5, 2022 23:42
tuxcanfly
tuxcanfly approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@tynes tynes merged commit 1d2567c into ethereum-optimism:develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxcanfly tuxcanfly tuxcanfly approved these changes

@tynes tynes tynes approved these changes

@Inphi Inphi Awaiting requested review from Inphi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mslipper @tuxcanfly @Inphi @tynes