Fix exit code when no matches found #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes 2 related issues: 1. `GetContentsMatches` of pattern matches never returns `nil`, but sometimes it returns an empty slice. So the condition was changed, while maintaining BC (nil slice's length is still 0) 2. `matchedAny` should not be set to true for every matched file. Instead, it should be set only if there is an actual problem reported in this file.
|
Good catch. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 2 related issues:
GetContentsMatchesof pattern matches never returnsnil, butsometimes it returns an empty slice. So the condition was changed,
while maintaining BC (nil slice's length is still 0)
matchedAnyshould not be set to true for every matched file.Instead, it should be set only if there is an actual problem reported
in this file.