Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ricardian-contracts): content and compiling example #274

Merged
merged 5 commits into from
Jul 7, 2021
Merged

feat(ricardian-contracts): content and compiling example #274

merged 5 commits into from
Jul 7, 2021

Conversation

leisterfrancisco
Copy link
Member

What does this PR do ?

Add clauses and contracts explanation of a Ricardian Contract

Steps to test

  1. yarn install
  2. yarn start
  3. go to http://localhost:3000/docs/aprender-eosio/contratos-ricardianos

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

AngeloCG97
AngeloCG97 previously approved these changes Jul 2, 2021
View reviewed changes
xavier506
xavier506 approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 self-requested a review July 4, 2021 20:52
xavier506
xavier506 requested changes Jul 4, 2021
View reviewed changes
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leisterfrancisco lets include a link to our react component that renders ricardian contracts:

https://components.eosio.cr/

xavier506
xavier506 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 490d721 into eoscostarica:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@AngeloCG97 AngeloCG97 Awaiting requested review from AngeloCG97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leisterfrancisco @xavier506 @AngeloCG97